One of most annoying things during Gerrit reviews are “unnecessary whitespaces” change discussion. This applies for the contributors and the reviewers.
As we in the Eclipse platform.ui project currently see a flow incoming Gerrit reviews from various people, I want to minimize these issues to keep everyone involved in this process happy. Therefore I started to cleanup the existing whitespaces and a activate the save actions on the project to avoid the creation of new whitespace.
If you also would like to do this use Source -> Clean-up on your source folder and activate afterwards the “Remove unnecessary whitespace” save action via the project setting.
Eclipse can be instructed to ignore these changes in its blame annotations via the “Ignore whitespace changes” preference setting in Team -> Git.
With these changes you bite the bullet once but afterwards the Gerrit review process becomes much more enjoyable.
Have you a solution to check this in Gerrit and have some agent voting -1 if the rules are broken?
@Jérémie, I’m unaware of such a plug-in.
Interesting that you mention this.
We previously cleared white spaces from the swt GTK code base,
We now have task to clear it out from SWT alltogether after M7:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=458808
Interesting proposition by Jérémie Bresson btw.